Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36889 - Add error message to indicate failed authentication #9890

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fixes #36889 - Add error message to indicate failed authentication #9890

merged 1 commit into from
Nov 8, 2023

Conversation

nofaralfasi
Copy link
Contributor

No description provided.

@nofaralfasi nofaralfasi force-pushed the 36889_expired_token branch 3 times, most recently from 4ae70ae to b95cce5 Compare November 6, 2023 18:03
ekohl
ekohl requested changes Nov 6, 2023
View reviewed changes
app/controllers/api/base_controller.rb Outdated Show resolved Hide resolved
app/services/sso/jwt.rb Outdated Show resolved Hide resolved
app/services/sso/jwt.rb Outdated Show resolved Hide resolved
ekohl
ekohl previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the setup to test this right now, but the code reads well to me.

@stejskalleos stejskalleos self-assigned this Nov 8, 2023
stejskalleos
stejskalleos approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

@stejskalleos stejskalleos merged commit 1eb33c7 into theforeman:develop Nov 8, 2023
6 checks passed
@stejskalleos
Copy link
Contributor

Thanks @nofaralfasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos stejskalleos approved these changes

@ekohl ekohl ekohl left review comments

Assignees

@stejskalleos stejskalleos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nofaralfasi @stejskalleos @ekohl